support regexp lookaround assertions in syntax files#4014
Closed
suchipi wants to merge 1 commit intomicro-editor:masterfrom
Closed
support regexp lookaround assertions in syntax files#4014suchipi wants to merge 1 commit intomicro-editor:masterfrom
suchipi wants to merge 1 commit intomicro-editor:masterfrom
Conversation
…kahead/lookbehind
Member
|
The reason why we didn't use it so far is the increased execution time, which isn't deterministic any longer. |
Author
|
Makes sense. I'll close this, since post-optimization the codebase will have changed enough that this diff won't be relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change makes syntax highlighting use dlclark/regexp2 instead of the standard library regexp package so that syntax files can use lookahead/lookbehind assertions.
in-buffer search is unchanged to avoid the UI freezing from bad lookbehinds
disclosure: this diff was generated by claude code